-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 963 deferred form #386
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I sent an email with this info, but here it is as well.
Since the Fastlane code is on the Marketo block and this block is used for all marketo forms, some visitors are receiving the Fastlane playbok when they are not supposed to. The Fastlane playbook should only fire for the form on the following page merative.com/contact.
Can we please come up with a solution on how to update the marketo block script to get the Fastlane code to only fire for the form on merative.com/contact.
@keith-kaplan the logic here has been updated so that the playbook only fires on the /contact path. |
@joehanchoi @chandans1316 were either of you able to successfully submit a form the dev domain here? https://issue-963-deferred-form--merative2--hlxsites.hlx.page/contact I wasn't able to submit any marketo form with this new change. See video. 2024-07-10_15-18-38.mp4Can you please take another pass at this? |
I have turned off fastlane playbook for now. If you need to do further testing, what I'd recommend is we remove the fastlane code from our production instance and then open a new PR to work on this. Right now, if we turn on fastlane it is enabled across the whole site. Another idea, I may have is if we create a new block that specific to the fastlane code and just use that block on the contact us page. All other marketo forms will use the existing marketo form block. |
All drift code has been commented out of the post-submit hook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just confirmed I'm able to submit the form successfully. GOing to merge.
Issue
Fixes: https://merative.atlassian.net/browse/MERATIVE-963
Description
Test URLs
main
): https://main--merative2--hlxsites.aem.page/contact