Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 963 deferred form #386

Merged
merged 6 commits into from
Jul 19, 2024
Merged

Issue 963 deferred form #386

merged 6 commits into from
Jul 19, 2024

Conversation

chandans1316
Copy link
Collaborator

Issue

Fixes: https://merative.atlassian.net/browse/MERATIVE-963

Description

Enable Deferred form submissions with Drift Fast Lane Playbook.

Test URLs

Copy link

aem-code-sync bot commented Jun 17, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Jun 17, 2024

Page Scores Audits Google
/contact PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@joehanchoi joehanchoi self-assigned this Jun 27, 2024
@joehanchoi joehanchoi self-requested a review June 27, 2024 16:27
@keith-kaplan keith-kaplan self-requested a review June 27, 2024 19:49
Copy link
Collaborator

@keith-kaplan keith-kaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sent an email with this info, but here it is as well.

Since the Fastlane code is on the Marketo block and this block is used for all marketo forms, some visitors are receiving the Fastlane playbok when they are not supposed to. The Fastlane playbook should only fire for the form on the following page merative.com/contact.

Can we please come up with a solution on how to update the marketo block script to get the Fastlane code to only fire for the form on merative.com/contact.

@aem-code-sync aem-code-sync bot temporarily deployed to issue-963-deferred-form June 28, 2024 13:22 Inactive
@joehanchoi joehanchoi requested a review from keith-kaplan July 5, 2024 15:13
@joehanchoi
Copy link
Collaborator

@keith-kaplan the logic here has been updated so that the playbook only fires on the /contact path.

@aem-code-sync aem-code-sync bot temporarily deployed to issue-963-deferred-form July 8, 2024 14:11 Inactive
@keith-kaplan
Copy link
Collaborator

@joehanchoi @chandans1316 were either of you able to successfully submit a form the dev domain here? https://issue-963-deferred-form--merative2--hlxsites.hlx.page/contact

I wasn't able to submit any marketo form with this new change. See video.

2024-07-10_15-18-38.mp4

Can you please take another pass at this?

@keith-kaplan
Copy link
Collaborator

I have turned off fastlane playbook for now. If you need to do further testing, what I'd recommend is we remove the fastlane code from our production instance and then open a new PR to work on this. Right now, if we turn on fastlane it is enabled across the whole site.

Another idea, I may have is if we create a new block that specific to the fastlane code and just use that block on the contact us page. All other marketo forms will use the existing marketo form block.

@aem-code-sync aem-code-sync bot temporarily deployed to issue-963-deferred-form July 19, 2024 09:23 Inactive
@joehanchoi
Copy link
Collaborator

All drift code has been commented out of the post-submit hook.

@joehanchoi joehanchoi self-requested a review July 19, 2024 14:46
Copy link
Collaborator

@keith-kaplan keith-kaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just confirmed I'm able to submit the form successfully. GOing to merge.

@keith-kaplan keith-kaplan merged commit defa518 into main Jul 19, 2024
2 checks passed
@keith-kaplan keith-kaplan deleted the issue-963-deferred-form branch July 19, 2024 14:54
@chandans1316 chandans1316 restored the issue-963-deferred-form branch August 1, 2024 14:43
@aem-code-sync aem-code-sync bot temporarily deployed to issue-963-deferred-form August 1, 2024 14:43 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants